Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data-3419: Upload Model Framework Into Package Metadata Using CLI #4556

Conversation

etai-shuchatowitz
Copy link
Member

@etai-shuchatowitz etai-shuchatowitz commented Nov 14, 2024

Context: https://viam.atlassian.net/browse/DATA-3419?atlOrigin=eyJpIjoiN2QyYmE5NWQyOGU3NDYwNzlmMGM3ZGU4MWU3YjMyMjAiLCJwIjoiaiJ9

We have an issue where if you upload an ML model using the CLI you can't specify the model framework. This was giving the CV team issues where a Tensorflow model was showing up as TFLite.

This extends the CLI to, not just allow, but require, a model-framework argument when uploading a package of type=ml_model

Testing

Ran

go run cli/viam/main.go packages upload --org-id="3a34383a-fadd-4426-9219-261f1ecbb804" --path="test.json" --name="etai_test_upload_ml_framework" --version="blah1" --type="ml_model" --model-framework="tensorflow"

And see:
Screenshot 2024-11-14 at 1 33 20 PM

Running

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 14, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 14, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 14, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 14, 2024
@etai-shuchatowitz etai-shuchatowitz merged commit d298b6b into viamrobotics:main Nov 14, 2024
16 checks passed
@etai-shuchatowitz etai-shuchatowitz deleted the DATA-3419/upload-metadata-from-cli branch November 14, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants