Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add course to the list #220

Merged
merged 2 commits into from
Nov 24, 2018
Merged

Add course to the list #220

merged 2 commits into from
Nov 24, 2018

Conversation

saqibameen
Copy link
Contributor

Added course to the list.

Name of the extension you are adding

NA

Why do you think this extension is awesome?

NA

Make sure that:

NA

  • Screenshot/GIF included (to demonstrate the plugin functionality)

  • ToC updated

Add VSCode Courses into the list.
@lannonbr
Copy link
Collaborator

Looks great. Thanks @saqibameen for the addition! Merging.

@lannonbr lannonbr merged commit 5c1fa1c into viatsko:master Nov 24, 2018
@viatsko
Copy link
Owner

viatsko commented Nov 24, 2018

I have to recall the merge.

This course is commercial and we need to have a really strong reason to go ahead with adding it to a collection. We don't want to be a platform for advertising commercial products.

We've made an exception for a Monokai Pro theme which is heavily recognized in a community and we highlighted it's commercial basis as much as we can. If we'll decide to proceed with the courses section, we'll come up with a solution matching that.

@lannonbr
Copy link
Collaborator

Let me make an issue to continue this discussion then.

@lannonbr
Copy link
Collaborator

See #222 for a continuation on a discussion for listing commercial resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants