Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back stdx.allocator -> std.experimental.allocator ? #383

Closed
wants to merge 1 commit into from

Conversation

denizzzka
Copy link
Contributor

@denizzzka denizzzka commented Feb 6, 2024

Looks like allocator is stable now and bug is fixed: https://issues.dlang.org/show_bug.cgi?id=17564

History: Use the stable stdx-allocator DUB package

@denizzzka
Copy link
Contributor Author

Looks it is better will be public import allocator headers from vibe-containter?

@s-ludwig
Copy link
Member

s-ludwig commented Feb 9, 2024

Sounds like a good idea, it should hopefully be stable enough nowadays and the past breaking changes are outside of our compiler support window.

I've opened vibe-d/vibe.d#2777 and vibe-d/vibe-container#2 to prepare for making the change in vibe-container. Then there just needs to be a basic CI step in vibe-container that compiles the whole of vibe.d to ensure we don't break anything accidentally. Once that is in place, can you re-apply your adjustments there?

s-ludwig added a commit to vibe-d/vibe-container that referenced this pull request Feb 9, 2024
@s-ludwig
Copy link
Member

s-ludwig commented Feb 9, 2024

Okay vibe.d is now tested in vibe-container and all places now refer to vibe.container.internal.utilallocator: vibe-d/vibe-container#3

@denizzzka denizzzka closed this Feb 9, 2024
@s-ludwig
Copy link
Member

Progress:

So this requires a lot more changes than anticipated due to the switch to RCIAllocator, but its getting there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants