Work on scope warnings and code cleanup #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y manually marking methods as scope.
Uses SortedRange.groupBy instead of performing the grouping manually and uses lambda function syntax to shorten the range chain.
l-kramer
approved these changes
Jul 4, 2023
Geod24
approved these changes
Jul 5, 2023
|
@s-ludwig : What's missing for a new release ? |
|
I've tagged v0.9.7-alpha.3 now. A fix for #2735 should probably land in master before v0.9.7 final is tagged, but apart from that, there shouldn't be any blocker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of some scope warnings, silences some with
@trustedand cleans up some code to minimize the amount of changes needed to get rid of the warnings.