Bug fix: #290 run apt only on required packages #291
Conversation
Error condition will output to console, but script will continue to install dependencies.
| if [ $? -ne 0 ]; then echo "ERROR: 'apt-get update' failed with error code: $?"; exit 1; fi | ||
|
|
||
| echo | ||
| sudo apt update --allow-releaseinfo-change || true |
There was a problem hiding this comment.
This will disable the error checking on apt update. If apt fails to update, then the installs may result in outdated and or incompatible packages.
I feel like if there's an error running apt update, it should be addressed by the end user rather than ignoring it.
There was a problem hiding this comment.
I added it back in a little further down in the next commit
+14
Altogether, it does check for updates, but if there is an error with apt update, it will output the error message to the user so they can address it. In either case it will still attempt to install pikaraoke
There was a problem hiding this comment.
If you force "|| true" though, wont the $? return 0? If that's the case then line 14 will never throw the error.
On the other point, suppose a bad repository is accessed before the valid pikaraoke dependent-repositories are. The script would error AND the install would occur with out of date repositories. I don't see a way to handle this cleanly.
fixes a case #290 where the user has a package that triggers this error:
E: The repository '...' does not have a Release filewhen running
sudo apt-get upgrade, by upgrading / installing only what pikaraoke needs