passing errors instead of strings to observables (#26)

videogorillas · Feb 19, 2024 · 93601bf · 93601bf
1 parent 9237201
commit 93601bf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "yuv-rx",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "Reading videos as Rx Observables of decoded frames",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/src/parser.ts b/src/parser.ts
@@ -122,9 +122,9 @@ export class YuvParser {
                 error: subscriber.error,
                 complete: () => {
                     if (buffer.length != 0) {
-                        subscriber.error(`Unparsed ${buffer.length} bytes in the end of the stream`);
+                        subscriber.error(new Error(`Unparsed ${buffer.length} bytes in the end of the stream`));
                     } else if (state == 'reading frame') {
-                        subscriber.error('Parser finished while expecting frame data');
+                        subscriber.error(new Error('Parser finished while expecting frame data'));
                     } else {
                         subscriber.complete();
                     }

diff --git a/src/reader.ts b/src/reader.ts
@@ -60,14 +60,14 @@ function yuv4mpegStream(ffmpeg: string, args: string[], options?: Y4MStreamOptio
         child.on('exit', (code?: number, signal?: NodeJS.Signals) => {
             exited = true;
             if (options?.verbose) {
-                console.log(`FFMpeg exited with code ${code}, signal ${signal}`);
+                console.log(new Error(`FFMpeg exited with code ${code}, signal ${signal}`));
             }
             if (code != null && code == 0) {
                 if (child.stdout.readableEnded) {
                     subscriber.complete();
                 }
             } else {
-                subscriber.error(`FFMpeg exited with exit code ${code}, signal ${signal}`);
+                subscriber.error(new Error(`FFMpeg exited with exit code ${code}, signal ${signal}`));
             }
         });
         child.stdout.on('end', () => {