Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix CI] write_coverage -> write-coverage #608

Merged
merged 2 commits into from
Oct 10, 2018
Merged

[Fix CI] write_coverage -> write-coverage #608

merged 2 commits into from
Oct 10, 2018

Conversation

tyru
Copy link
Member

@tyru tyru commented Oct 10, 2018

No description provided.

@tyru
Copy link
Member Author

tyru commented Oct 10, 2018

  • covimerage changed subcommand: write_coverage -> write-coverage
  • Default covimerage output filename (--data-file) is .coverage_covimerage, but coveragerc says .coverage.covimerage
    • So coverage.py tries to find the file but it doesn't exist
    • (why did it work? it may not be changed from before, and --data-file is not specified)

@tyru tyru requested review from ujihisa and thinca October 10, 2018 23:08
@tyru
Copy link
Member Author

tyru commented Oct 10, 2018

please approve this...

@thinca thinca changed the title [Fix CI] write_coverage -> write-covimerage [Fix CI] write_coverage -> write-coverage Oct 10, 2018
@tyru tyru merged commit 080d0af into master Oct 10, 2018
@tyru tyru deleted the fix-ci branch October 10, 2018 23:53
@tyru tyru mentioned this pull request Oct 11, 2018
Merged
@tyru
Copy link
Member Author

tyru commented Oct 11, 2018 •
edited
Loading

write_coverage -> write-coverage change was caused by bug, it seems write_coverage is the right name.
So we have to revert write-coverage to write_coverage after the latest one is uploaded to pypi.

via Vimjas/covimerage#57

blueyed
blueyed reviewed Oct 11, 2018
View reviewed changes
.coveragerc
@@ -1,3 +1,3 @@
[run]
plugins = covimerage
data_file = .coverage.covimerage
data_file = .coverage_covimerage
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JFI: this is required since the default in covimerage changed (because .coverage.foo gets picked up typically with coverage combine (for a .coverage data_file) - therefore I've changed it to .coverage_foo`). Slightly related: Vimjas/covimerage#51

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. thanks for information!

@tyru tyru mentioned this pull request Oct 11, 2018
Merged
@tyru tyru mentioned this pull request Oct 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueyed blueyed blueyed left review comments

@thinca thinca thinca approved these changes

@ujihisa ujihisa Awaiting requested review from ujihisa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyru @blueyed @thinca