Button padding change #272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanbrud
force-pushed
the
button-padding-change
branch
from
2a26b44
to
559b567
Compare
nathanbrud
force-pushed
the
button-padding-change
branch
from
559b567
to
36a818b
Compare
|
I'd like to discuss this approach with @juliewongbandue a little bit more. It would be a larger change, but it might be worth examining why are sizing our icons in such a complex way. |
|
Sure, I tried to do it less intrusive but removing complexity is always good. If you want to loop me in too would be great. Anyway that my way of suggesting the solution and if you think we should go another way I can change it 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Change the padding for sm/xs buttons based on https://vimean.atlassian.net/browse/DSYS-1
Screenshots & Recordings
How it does that
For general padding change the padding values per size.
For sm/xs specifically there are padding adjustments needed because the current logic doesn't cover it so added a map with adjustments to the end result for the requested values.
Testing
Use sm/xs button with / without text and see padding looks ok.
Added tests for padding size based on button size.