add disabled as prop to support visibilty modes of tooltip #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sbatel can you add unit tests for this component as well? |
juliewongbandue
requested changes
Jul 31, 2023
juliewongbandue
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
this change is needed to prevent situations like this -
we would like to hide the tooltip when the popover is open (the tooltip wraps the button the is wrapped by the popover)
Support the ability to disable/enable tooltip (control visibility).
similar to bootstrap's tooltip disable prop -> https://getbootstrap.com/docs/4.0/components/tooltips/#tooltipdisable
Screenshots & Recordings
Screen-Recording-2023-07-27-at-3.07.36-PM.mp4
How it does that
Added the 'disabled' prop (default value is false) that effects the Tip's style (visibility: visible/hidden)
In addition I edited the Active story to reflect better what exactly it does.
Screen-Recording-2023-07-27-at-3.11.25-PM.mp4
Tests
Add unit tests to the component on file Tip.test.tsx