Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEWK-2840 ColorSelect2 redesign #346

Merged
merged 9 commits into from
Aug 20, 2023
Merged

Conversation

alonmeiri
Copy link
Collaborator

@alonmeiri alonmeiri commented Aug 16, 2023

Closes: https://vimean.atlassian.net/browse/CEWK-2840?focusedCommentId=786710&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-786710

What this PR does

  • Style ColorSelect2 according to updated design
  • Add disabled prop to ColorSelect2
  • Move Presets internally into the ColorSelect2 popover according to design and add presets prop
  • Update storybook
  • Update & add tests

Screenshots & Recordings

Screenshot 2023-08-16 at 17 58 29

Testing

@juliewongbandue
Copy link
Collaborator

Since there's an update to what the ColorSelect2 looks like with presets, could you also include a story for ColorSelect2 input? (the display of this can just live alongside the preset button, for visual regression snapshot purposes)

@juliewongbandue
Copy link
Collaborator

It would also be beneficial to show the disabled state of this component as well

@alonmeiri
Copy link
Collaborator Author

Since there's an update to what the ColorSelect2 looks like with presets, could you also include a story for ColorSelect2 input? (the display of this can just live alongside the preset button, for visual regression snapshot purposes)

@juliewongbandue not sure I follow what you mean? Isn't that the same as the ColorSelect2 story?

@juliewongbandue
Copy link
Collaborator

Since there's an update to what the ColorSelect2 looks like with presets, could you also include a story for ColorSelect2 input? (the display of this can just live alongside the preset button, for visual regression snapshot purposes)

@juliewongbandue not sure I follow what you mean? Isn't that the same as the ColorSelect2 story?

@alonmeiri sorry for the confusion. Yes, the ColorSelect and ColorSelect2 stories are the same, but since the ColorSelect2 has modified the props with the presets being on the inside of the component, I was thinking of just presenting the content of the popover in the ColorSelect2 in a story:

Screenshot 2023-08-17 at 9 03 14 AM
Screenshot 2023-08-17 at 9 04 21 AM

So this: https://github.com/vimeo/iris/blob/CEWK-2840-colorselect2-design-update/src/components/inputs/ColorSelect2/ColorSelect2.tsx#L86-L115 with its' different possible states, so we can just keep track of it with our visual regression tool. Does that make sense?

@alonmeiri alonmeiri merged commit af63f94 into main Aug 20, 2023
8 checks passed
@alonmeiri alonmeiri deleted the CEWK-2840-colorselect2-design-update branch August 20, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants