-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CEWK-2840 ColorSelect2 redesign #346
Conversation
Co-authored-by: alonmeiri <[email protected]>
Since there's an update to what the |
It would also be beneficial to show the disabled state of this component as well |
@juliewongbandue not sure I follow what you mean? Isn't that the same as the |
Co-authored-by: alonmeiri <[email protected]>
@alonmeiri sorry for the confusion. Yes, the ColorSelect and ColorSelect2 stories are the same, but since the ColorSelect2 has modified the props with the presets being on the inside of the component, I was thinking of just presenting the content of the popover in the ColorSelect2 in a story: So this: https://github.com/vimeo/iris/blob/CEWK-2840-colorselect2-design-update/src/components/inputs/ColorSelect2/ColorSelect2.tsx#L86-L115 with its' different possible states, so we can just keep track of it with our visual regression tool. Does that make sense? |
Co-authored-by: alonmeiri <[email protected]>
Co-authored-by: juliewongbandue <[email protected]>
Closes: https://vimean.atlassian.net/browse/CEWK-2840?focusedCommentId=786710&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-786710
What this PR does
ColorSelect2
according to updated designdisabled
prop toColorSelect2
Presets
internally into theColorSelect2
popover according to design and addpresets
propScreenshots & Recordings
Testing