Add textColor to Button color prop #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliewongbandue
temporarily deployed
to
development
GitHub Actions
Inactive
juliewongbandue
commented
Sep 20, 2023
juliewongbandue
had a problem deploying
to
development
GitHub Actions
Failure
juliewongbandue
force-pushed
the
button-style-accessibility
branch
from
96fe364
to
d2e685b
Compare
juliewongbandue
temporarily deployed
to
development
GitHub Actions
Inactive
juliewongbandue
force-pushed
the
button-style-accessibility
branch
from
62e8e22
to
18a1d1f
Compare
juliewongbandue
temporarily deployed
to
development
GitHub Actions
Inactive
Co-authored-by: juliewongbandue <[email protected]>
tylerthegrove
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds ability to specify
textColorfor button to support button customization.Storybook
Screenshots & Recordings
How it does that
Adds textColor to color prop. If only color is provided, returns a readable text color based on the color provided.