Fix

vimeo · Jul 24, 2023 · a86aa9a · a86aa9a
1 parent dfbc9dd
commit a86aa9a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/Psalm/Internal/Type/TypeCombiner.php b/src/Psalm/Internal/Type/TypeCombiner.php
@@ -1034,8 +1034,11 @@ private static function scrapeStringProperties(
                 ) {
                     // do nothing
                 } elseif (isset($combination->value_types['string'])
-                    && $combination->value_types['string'] instanceof TNonFalsyString
-                    && $type->value
+                    && $combination->value_types['string'] instanceof TNonEmptyString
+                    && ($combination->value_types['string'] instanceof TNonFalsyString
+                        ? $type->value
+                        : $type->value !== ''
+                    )
                 ) {
                     // do nothing
                 } else {