Ensure TaintTest datasets have unique keys

vimeo · Jan 2, 2023 · c6879ef · c6879ef
1 parent a5fe942
commit c6879ef
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/tests/TaintTest.php b/tests/TaintTest.php
@@ -867,7 +867,7 @@ public function providerInvalidCodeParse(): array
             'array_values([$_GET["a"]])',
         ]);
 
-        return array_merge([
+        $otherDataSets = [
             'taintedInputFromMethodReturnTypeSimple' => [
                 'code' => '<?php
                     class A {
@@ -2598,7 +2598,22 @@ public static function getPrevious(string $s): string {
                     echo pg_escape_string($conn, $_GET["a"]);',
                 'error_message' => 'TaintedHtml',
             ],
-        ], $arrayFunctionTaintFlowDataSets);
+        ];
+
+        $dataSetsArrays = [
+            $otherDataSets,
+            $arrayFunctionTaintFlowDataSets
+        ];
+
+        $expectedCount = 0;
+        foreach($dataSetsArrays as $array){
+            $expectedCount += count($array);
+        }
+
+        $mergedDataSets = array_merge(...$dataSetsArrays);
+        $this->assertSame($expectedCount, count($mergedDataSets), "Please make sure none of the datasets have duplicate keys!");
+
+        return $mergedDataSets;
     }
 
     /**