Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-work CheckTrivialExprVisitor #10612

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Re-work CheckTrivialExprVisitor #10612

merged 1 commit into from
Jan 29, 2024

Commits on Jan 29, 2024

  1. Re-work CheckTrivialExprVisitor 

    In php-parser 5.0, `ClosureUse` is no longer considered an expression.
This requires changes to Psalm's `CheckTrivialExprVisitor`, which stores
an array of "non-trivial" `Expr` nodes.

However the only use of this array is to count whether or not it's
empty. Instead of keeping the array, we can keep a boolean, and avoid
needing to change the types in this class when we upgrade to php-parser
5.0.
    @edsrzf
    edsrzf committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    98d98be View commit details
    Browse the repository at this point in the history