Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more precise return types for getimagesize* functions #11042

Open
wants to merge 3 commits into
base: 5.x
Choose a base branch
from

Conversation

MidnightDesign
Copy link
Contributor

@MidnightDesign MidnightDesign commented Jul 11, 2024

  • Key 0 (the image width) is always >= 0
  • Key 1 (the image height) is always >= 0
  • Key 2 is always one of the IMAGETYPE_* constants

…ring

- Key 0 (the image width) is always positive
- Key 1 (the image height) is always positive
- Key 2 is always one of the `IMAGETYPE_*` constants
@MidnightDesign
Copy link
Contributor Author

Is there an easy way to add tests for these signature changes?

@weirdan
Copy link
Collaborator

weirdan commented Sep 7, 2024

You also need to update either the delta files or the historic callmap. See https://psalm.dev/docs/contributing/editing_callmaps/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants