Skip to content

Commit

Permalink
Fix issue ionic-team#173 ionic-team#212 delete deprecated event
Browse files Browse the repository at this point in the history
  • Loading branch information
VinhBT committed Oct 11, 2017
1 parent 9da969a commit d390bff
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
4 changes: 0 additions & 4 deletions src/ios/IonicKeyboard.m
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ - (void)pluginInitialize {

[weakSelf.commandDelegate evalJs:[NSString stringWithFormat:@"cordova.plugins.Keyboard.isVisible = true; cordova.fireWindowEvent('native.keyboardshow', { 'keyboardHeight': %@ }); ", [@(keyboardFrame.size.height) stringValue]]];

//deprecated
[weakSelf.commandDelegate evalJs:[NSString stringWithFormat:@"cordova.fireWindowEvent('native.showkeyboard', { 'keyboardHeight': %@ }); ", [@(keyboardFrame.size.height) stringValue]]];
self.keyboardIsVisible = true;
}
}];
Expand All @@ -55,8 +53,6 @@ - (void)pluginInitialize {

[weakSelf.commandDelegate evalJs:@"cordova.plugins.Keyboard.isVisible = false; cordova.fireWindowEvent('native.keyboardhide'); "];

//deprecated
[weakSelf.commandDelegate evalJs:@"cordova.fireWindowEvent('native.hidekeyboard'); "];
self.keyboardIsVisible = false;
}
}];
Expand Down
6 changes: 0 additions & 6 deletions www/android/keyboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,9 @@ channel.onCordovaReady.subscribe(function() {
var keyboardHeight = msg.substr(1);
cordova.plugins.Keyboard.isVisible = true;
cordova.fireWindowEvent('native.keyboardshow', { 'keyboardHeight': + keyboardHeight });

//deprecated
cordova.fireWindowEvent('native.showkeyboard', { 'keyboardHeight': + keyboardHeight });
} else if ( action === 'H' ) {
cordova.plugins.Keyboard.isVisible = false;
cordova.fireWindowEvent('native.keyboardhide');

//deprecated
cordova.fireWindowEvent('native.hidekeyboard');
}
}
});
Expand Down

0 comments on commit d390bff

Please sign in to comment.