Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finally changed the UI (again) #85

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Finally changed the UI (again) #85

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 12, 2016

  • PokemonGO themed
  • Less bootstrap-like
  • ++ cool :D

capture du 2016-08-12 16-00-16
capture du 2016-08-12 16-00-59
capture du 2016-08-12 16-03-25

@mackhankins
Copy link
Collaborator

Where did the checkboxes go for the pokemon tables?

@vinnymac
Copy link
Owner

vinnymac commented Aug 12, 2016

This is a big visual change, wow! Really interesting design choices! I really like that you made the login screen bigger, that was bothering me.

I am not sure I like the transparent table rows though, it takes away from finding the information you are looking for, and the background will be distracting to the eyes.

Curious if #76 will break all the table styles you added.

Join us on Discord sometime.

@ghost
Copy link
Author

ghost commented Aug 12, 2016

@mackhankins My bad, I corrected the checkboxes in this last commit.

@vinnymac I totally agree that's not optimal, I'm still searching for better list UI and I 'll push it when I got something better

@vinnymac
Copy link
Owner

Maybe we should make the search bar bigger and more square. @Khogniak what do you think? I have been working on search in the react tables pull request, and I think it looks bad just floating out on the right like that.

@ghost
Copy link
Author

ghost commented Aug 12, 2016

I 'll try a new header tomorrow, including page title, search bar and tools. So header will have a real use and we are going to gain space for the table. Also with this design we could transfer and evolve without scrolling back to top.
Seems good to you?

@vinnymac vinnymac added this to the v1.2 milestone Aug 15, 2016
@mackhankins
Copy link
Collaborator

You should pull down the develop branch to see what we've done. I really love the login screen and wish that was it's on pull request.

@vinnymac vinnymac modified the milestones: Future, v1.2 Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants