Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Compile SDK 29 -> 33 #22

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Bump Compile SDK 29 -> 33 #22

merged 1 commit into from
Aug 22, 2023

Conversation

ArnasSmicius
Copy link
Contributor

Bumping Compile SDK to 29 -> 33. Because some 3rd party #21 library versions require that. Also, it is healthy to update this version.
Also migrated deprecated compileSdkVersion -> compileSdk and minSdkVersion -> minSdk

Everything works as expected. I can't find any changes that affect this library

@ArnasSmicius ArnasSmicius requested a review from a team August 22, 2023 07:33
Copy link
Contributor

@kyrillosgait kyrillosgait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ArnasSmicius ArnasSmicius merged commit 4b70a0d into master Aug 22, 2023
1 check passed
@ArnasSmicius ArnasSmicius deleted the technical/compile_sdk_33 branch August 22, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants