Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Robolectric 4.3 -> 4.10.3 #42

Merged
merged 9 commits into from
Sep 29, 2023

Conversation

kyrillosgait
Copy link
Contributor

@kyrillosgait kyrillosgait commented Sep 29, 2023

Upgraded Robolectric to newest version. Mainly adjusted usage of argument matches and timing when stubbing.

Removed unnecessary stubbing of requestPermissions method.
Previously `anyOrNull()` matcher was used, which covered stubbing the method for all ints. Now it stubs only the method for only the specified `requestCode` which results into method not stubbed when `requestPermissions` is called from `CoperFragment#requestPermissionsAsync`.
@kyrillosgait kyrillosgait marked this pull request as ready for review September 29, 2023 11:06
@kyrillosgait kyrillosgait requested a review from a team September 29, 2023 11:06
@kyrillosgait kyrillosgait changed the base branch from technical/jdk11 to master September 29, 2023 13:25
@kyrillosgait kyrillosgait merged commit b6f0e4b into master Sep 29, 2023
1 check passed
@kyrillosgait kyrillosgait deleted the technical/upgrade_robolectric_4_10 branch September 29, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants