Skip to content

Commit

Permalink
boost: cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
benetis committed Mar 27, 2024
1 parent 1c21527 commit 75f3099
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 21 deletions.
2 changes: 0 additions & 2 deletions go/vt/sqlparser/analyzer.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ const (
StmtCallProc
StmtRevert
StmtShowMigrationLogs

StmtBoost
)

// ASTToStatementType returns a StatementType from an AST stmt
Expand Down
11 changes: 0 additions & 11 deletions go/vt/vtgate/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -1047,8 +1047,6 @@ func (e *Executor) StreamExecute(ctx context.Context, method string, safeSession
switch plan.Type {
case sqlparser.StmtBegin, sqlparser.StmtCommit, sqlparser.StmtRollback:
return vterrors.Errorf(vtrpcpb.Code_UNIMPLEMENTED, "OLAP does not supported statement type: %s", plan.Type)
//case sqlparser.StmtBoost:
// return e.handleBoost(ctx, safeSession, plan, bindVars, callback)
}

err = e.addNeededBindVars(plan.BindVarNeeds, bindVars, safeSession)
Expand Down Expand Up @@ -1547,12 +1545,3 @@ func (e *Executor) startVStream(ctx context.Context, rss []*srvtopo.ResolvedShar
vs.stream(ctx)
return nil
}

//
//// Instead of mysql query, query Redis with custom-built key
//func (e *Executor) handleBoost(ctx context.Context, session *SafeSession, plan *engine.Plan, vars map[string]*querypb.BindVariable, callback func(*sqltypes.Result) error) error {
//
// panic("not implemented")
// return nil
//
//}
8 changes: 0 additions & 8 deletions go/vt/vtgate/planbuilder/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,6 @@ func BuildFromStmt(query string, stmt sqlparser.Statement, reservedVars *sqlpars
return plan, nil
}

//func BuildBoost(query string, stmt sqlparser.Statement) (*engine.Plan, error) {
// return &engine.Plan{
// Type: sqlparser.StmtBoost,
// Instructions: &engine.EmptyPrimitive{},
// BindVarNeeds: &sqlparser.BindVarNeeds{},
// }, nil
//}

func getConfiguredPlanner(vschema ContextVSchema) (selectPlanner, error) {
switch vschema.Planner() {
case Gen4, Gen4Left2Right, Gen4GreedyOnly:
Expand Down

0 comments on commit 75f3099

Please sign in to comment.