Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding continueAfterCopyWithOwner flag #7

Closed
wants to merge 3 commits into from
Closed

adding continueAfterCopyWithOwner flag #7

wants to merge 3 commits into from

Conversation

DeathBorn
Copy link
Collaborator

Backporting vitessio#9771

Description

We did not check for the saved StopAfterCopy config value (➡️ here for the INSERT to generate the _vt.vreplication row) in the workflow when attempting to externalize it. When the -continue_after_copy_with_owner=true flag (added in v12.0) was used for the CreateLookupVindex command — which means that the _vt.vreplication.source value does not have stop_after_copy:true in it — the workflow state will be Running when it's healthy and we should be checking for that.

Instead, before this PR we would fail to externalize the VIndex when -continue_after_copy_with_owner=true was used and the workflow was running (as is expected and proper in that case) with an error here:

https://github.com/vitessio/vitess/blob/2c0a29df5d513167ac0f600d8916128b15d1063e/go/vt/wrangler/materializer.go#L776-L779

Related Issue(s)

Checklist

  • Should this PR be backported? YES, at least to release-13.0
  • Tests were updated
  • Documentation is not required

zhePin and others added 3 commits September 22, 2023 10:39
@zhePin @vbalys
adding continueAfterCopyWithOwner flag
4d028a5 
Signed-off-by: zhe <[email protected]>
@mattlord @vbalys
Externalize VIndexes properly when not stopping after copy
b4e50ec 
We did not check for this config state at externalize.
When -stop_after_copy=false was used for the lookup vindex
materialization the workflow state will be Running when
it's healthy.

Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Vaidas Balys <[email protected]>
@mattlord @vbalys
Update tests now that we check BinlogSource when externalizing lookup…
5d8fa9a 
… vindexes

Signed-off-by: Matt Lord <[email protected]>
@vbalys vbalys closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeathBorn @vbalys @zhePin @mattlord