-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize Error Handling #86
Comments
Hey, I want to work on this task can you please assign it to me?? @a-moreira @Davidson-Souza |
Hey @Vikaass-08 thanks for the interest. You got it! |
hey @Vikaass-08, first we need to list the crates and where we use them, so we can make sense of the reason they were picked. Then we will decide the best crate to use on the whole project, or if we are ditching them and using our custom macros. |
Ok let's work on that first. @a-moreira |
@Vikaass-08 nice, let us know if you need any help! |
Getting this Error during I have gone through the codebase and found Few CustomErrors that uses
Are we planning to combine these Errors, apart From these are there some other cases?? |
Oh, this is actually something we need to fix here. This is a known problem with rustc 1.73 IIRC, there's a backport in rust-miniscript, but we're using an out-of-tree version. For now, try using a compiler <1.73. I'm using 1.72.1. |
These are all the Errors that i Found in the codebase @a-moreira |
@Davidson-Souza @a-moreira |
I haven't seen any update in a while. You are welcome to open a pr addressing this |
I made a PR with a strategy that maybe can feel a little like unnecessary work, but to reverse the "Isolating the errors in a crate" is quite easy since the work is done and the project compiles without any bugs... |
We currently use multiple error handling crates like
anyhow
,thiserror
, and also custom macros.It'd be good to standardize this and pick one option.
The text was updated successfully, but these errors were encountered: