Standardize Error Handling

[a-moreira]

We currently use multiple error handling crates like anyhow, thiserror, and also custom macros.
It'd be good to standardize this and pick one option.

[Vikaass-08]

Hey, I want to work on this task can you please assign it to me?? @a-moreira @Davidson-Souza

[Davidson-Souza]

Hey @Vikaass-08 thanks for the interest. You got it!

[a-moreira]

hey @Vikaass-08, first we need to list the crates and where we use them, so we can make sense of the reason they were picked. Then we will decide the best crate to use on the whole project, or if we are ditching them and using our custom macros.

[Vikaass-08]

Ok let's work on that first. @a-moreira

[a-moreira]

@Vikaass-08 nice, let us know if you need any help!

[Vikaass-08]

Getting this Error during cargo build, can you help me with this?? @a-moreira

I have gone through the codebase and found Few CustomErrors that uses thisError.

• BlockchainError
• Error
• WireError
• PeerError

Are we planning to combine these Errors, apart From these are there some other cases??

[Davidson-Souza]

Oh, this is actually something we need to fix here. This is a known problem with rustc 1.73 IIRC, there's a backport in rust-miniscript, but we're using an out-of-tree version.

For now, try using a compiler <1.73. I'm using 1.72.1.

[Vikaass-08]

• BlockchainError
• Error
• WireError
• PeerError
• BlockValidationErrors
• KvDatabaseError
• WatchOnlyError
• Socks5Error

These are all the Errors that i Found in the codebase @a-moreira

[shivam-Purohit]

@Davidson-Souza @a-moreira
if this is going stale can i try it?

[Davidson-Souza]

I haven't seen any update in a while. You are welcome to open a pr addressing this

[jaoleal]

I made a PR with a strategy that maybe can feel a little like unnecessary work, but to reverse the "Isolating the errors in a crate" is quite easy since the work is done and the project compiles without any bugs...
And all the errors will "enherit" the native error, without the needing to reimplement the errors, but there are ones that i simply dont know who to enherit because is just a enum, for that ones i just displayed their names.