Support for Ghost Types #773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, cool! Do I see it correctly that, for two instances |
Felalolf
approved these changes
Sep 20, 2024
| case _: PBoolType | _: PIntegerType | _: PFloatType | _: PStringType | _: PFunctionType | _: PInterfaceType => false | ||
| case PArrayType(_, elem) => isTypeGhost(elem) | ||
| case PSliceType(elem) => isTypeGhost(elem) | ||
| case PMapType(key, elem) => isTypeGhost(key) && isTypeGhost(elem) |
There was a problem hiding this comment.
I think this should be a disjunction.
Suggested change
| case PMapType(key, elem) => isTypeGhost(key) && isTypeGhost(elem) | |
| case PMapType(key, elem) => isTypeGhost(key) || isTypeGhost(elem) |
There was a problem hiding this comment.
Also do the thing that Joao said
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Ghost Types, i.e., the ability to mark a named type or type alias as ghost such that this type is erased. This feature came up in the context of structs that are declared for verification-only purposes and, thus, contain only ghost fields.
In addition, this PR makes
PPermissionTypeandPPredTypeghost types, which did not use to be the case.