Rx memory #1105
Open
Rx memory #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the decisions about size of shared buffers for RXQ and allocation of shared memories. Create optimal layout of RX shared buffers before creation of queues; allocate the memories according the layout. Initially optimized layout is desabled and we create the "legacy" layout, fully compatible with what was done before. This commit contains only creation of the layout, it is not yet applied when allocating RX buffer's memories. Signed-off-by: Yuri Benditovich <[email protected]>
Signed-off-by: Yuri Benditovich <[email protected]>
https://issues.redhat.com/browse/RHEL-19814 Do not allocate redundant memory, use full 4K+ pages when needed, tail of the data (usually small) allocate together with header/indirect block and make this block smaller than 4K when possible. This reduces 10% of all the shared memory allocated for RX buffers. For non-RSC configuration it is possible to reduce much more (for future). Signed-off-by: Yuri Benditovich <[email protected]>
Currently the driver always assume the maximim packet size is ~64K as it is compiled with RSC support. The initial reason was that if the RSC is disabled by admin (registry value of the driver), it can be turned on by command, i.e. without disable-enable. However this depends also on host features. If the host does not support the GUEST_TSOx, RSC will be reported to the OS as not supported but the buffers are still huge without any reason. (In such case the powershell reports IPv4 and IPv6 operational state as Off even if the RSC keywords are enabled). The commit moves the decision to initialization time - if the RSC is not supported, the buffers are sized accoring to MTU. The memory consumption is lower 16 times. Signed-off-by: Yuri Benditovich <[email protected]>
|
NetKVM-Win2025x64 - 7 failures, the same as with PR-1104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.