feature(serializer): support encoding for number primitives under Compact<T> #7

pandres95 · 2022-12-10T01:18:04Z

No description provided.

…pact<T>

src/serializer.rs

…types

olanod

I made the change I suggested before of using match instead of matches :)
Something that would be left is replacing the codec dependency to correctly compile with --no-default-features and some tests of course ;)

…Enum-related values

olanod · 2022-12-21T08:29:30Z

@pandres95 I created #8 to track removing the dependency on scale-codec

feature(serializer): support encoding for number primitives under Com…

bd9d03a

…pact<T>

olanod suggested changes Dec 12, 2022

View reviewed changes

src/serializer.rs Outdated Show resolved Hide resolved

src/serializer.rs Outdated Show resolved Hide resolved

change(serializer): better assert type_def on serialize_compact

b989583

pandres95 requested a review from olanod December 14, 2022 01:40

change(serializer): on serialize_compact use self.resolve to resolve …

d5b3a26

…types

pandres95 force-pushed the feature/encode-compact branch from 8c16092 to d5b3a26 Compare December 14, 2022 04:43

pandres95 and others added 2 commits December 14, 2022 00:15

change(serializer): derive Debug on Serializer

15d1a52

Replace if matches! with match

56efb4f

olanod suggested changes Dec 16, 2022

View reviewed changes

pandres95 added 2 commits December 20, 2022 15:19

change(serializer): set TypedSerializer as debuggable

9a01abf

fix(serializer): on serialize_value, unwrap StructNewType(ty_id) for …

628cd1f

…Enum-related values

pandres95 requested a review from olanod December 20, 2022 21:29

olanod approved these changes Dec 21, 2022

View reviewed changes

Make clippy happy

95f89cb

olanod force-pushed the feature/encode-compact branch from 9df769f to 95f89cb Compare December 21, 2022 08:24

olanod merged commit cc3ae2a into virto-network:main Dec 21, 2022

pandres95 deleted the feature/encode-compact branch December 21, 2022 16:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(serializer): support encoding for number primitives under Compact<T> #7

feature(serializer): support encoding for number primitives under Compact<T> #7

pandres95 commented Dec 10, 2022

olanod left a comment

olanod commented Dec 21, 2022

feature(serializer): support encoding for number primitives under Compact<T> #7

feature(serializer): support encoding for number primitives under Compact<T> #7

Conversation

pandres95 commented Dec 10, 2022

olanod left a comment

Choose a reason for hiding this comment

olanod commented Dec 21, 2022