fix(pallet-communities-manager): limit to u16 / benchmark to 1,1024

virto-network · May 8, 2024 · 1bb052e · 1bb052e
1 parent 9aff757
commit 1bb052e
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/pallets/communities-manager/src/benchmarking.rs b/pallets/communities-manager/src/benchmarking.rs
@@ -5,6 +5,7 @@ use frame_benchmarking::v2::*;
 
 use frame_support::traits::fungible::Mutate;
 use frame_system::RawOrigin;
+use sp_runtime::SaturatedConversion;
 
 type RuntimeEventFor<T> = <T as Config>::RuntimeEvent;
 
@@ -58,7 +59,7 @@ mod benchmarks {
 	}
 
 	#[benchmark]
-	fn create_memberships() -> Result<(), BenchmarkError> {
+	fn create_memberships(q: Linear<1, 1024>) -> Result<(), BenchmarkError> {
 		// setup code
 		T::CreateCollection::create_collection_with_id(
 			T::MembershipsManagerCollectionId::get(),
@@ -74,7 +75,7 @@ mod benchmarks {
 		#[extrinsic_call]
 		_(
 			RawOrigin::Root,
-			u16::MAX.into(),
+			q.saturated_into(),
 			100u32.into(),
 			300_000_000_000u128.into(),
 		);
@@ -83,7 +84,7 @@ mod benchmarks {
 		assert_has_event::<T>(
 			Event::<T>::MembershipsCreated {
 				starting_at: 100u32.into(),
-				amount: u16::MAX.into(),
+				amount: q.saturated_into(),
 			}
 			.into(),
 		);

diff --git a/pallets/communities-manager/src/lib.rs b/pallets/communities-manager/src/lib.rs
@@ -176,11 +176,12 @@ pub mod pallet {
 			Ok(())
 		}
 
+		#[pallet::weight(<T as Config>::WeightInfo::create_memberships(*amount))]
 		#[pallet::call_index(1)]
 		pub fn create_memberships(
 			origin: OriginFor<T>,
-			#[pallet::compact] amount: u32,
-			#[pallet::compact] starting_at: <T as Config>::MembershipId,
+			amount: u16,
+			starting_at: <T as Config>::MembershipId,
 			#[pallet::compact] price: NativeBalanceOf<T>,
 		) -> DispatchResult {
 			T::CreateMembershipsOrigin::ensure_origin(origin)?;

diff --git a/pallets/communities-manager/src/weights.rs b/pallets/communities-manager/src/weights.rs
@@ -8,7 +8,7 @@ use core::marker::PhantomData;
 /// Weight functions needed for pallet_communities.
 pub trait WeightInfo {
 	fn register() -> Weight;
-	fn create_memberships() -> Weight;
+	fn create_memberships(q: u16, ) -> Weight;
 }
 
 /// Weights for pallet_communities using the Substrate node and recommended hardware.
@@ -53,7 +53,7 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
 			.saturating_add(T::DbWeight::get().writes(14))
 	}
 
-	fn create_memberships() -> Weight {
+	fn create_memberships(_: u16, ) -> Weight {
 		// Proof Size summary in bytes:
 		//  Measured:  `278`
 		//  Estimated: `132561`
@@ -105,7 +105,7 @@ impl WeightInfo for () {
 			.saturating_add(RocksDbWeight::get().writes(14))
 	}
 
-	fn create_memberships() -> Weight {
+	fn create_memberships(_: u16, ) -> Weight {
 		// Proof Size summary in bytes:
 		//  Measured:  `278`
 		//  Estimated: `132561`

diff --git a/runtime/kreivo/src/weights/pallet_communities_manager.rs b/runtime/kreivo/src/weights/pallet_communities_manager.rs
@@ -74,7 +74,7 @@ impl<T: frame_system::Config> pallet_communities_manager::WeightInfo for WeightI
 			.saturating_add(T::DbWeight::get().writes(14))
 	}
 
-	fn create_memberships() -> Weight {
+	fn create_memberships(_: u16, ) -> Weight {
 		// Proof Size summary in bytes:
 		//  Measured:  `278`
 		//  Estimated: `132561`