Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kreivo-runtime & virto-runtime build features #277

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

darkforest0202
Copy link
Contributor

Closes #272

To review after #276 and #274 are merged.

This PR is adding the kreivo-runtime & virto-runtime build features that allows more optimized builds choosing specific runtimes builds.

@olanod , CI pipelines can be enhanced by choosing only kreivo-runtime option.

Copy link
Member

@olanod olanod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the commented assertions in the test, is it for a particular reason?

@darkforest0202
Copy link
Contributor Author

Looks good to me except for the commented assertions in the test, is it for a particular reason?

that was a mistake, i was trying to fix something on the tests and i forgot to uncomment those .

@@ -1,6 +1,11 @@
[profile.release]
panic = 'unwind'

[profile.production]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olanod as discussed i added the production profile.

@olanod olanod merged commit b1fac91 into master Jul 12, 2023
@olanod olanod deleted the nicof-build-feauture branch July 12, 2023 10:30
@darkforest0202 darkforest0202 restored the nicof-build-feauture branch August 26, 2023 16:50
@pandres95 pandres95 deleted the nicof-build-feauture branch October 5, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve build with optional features.
2 participants