-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue community tokens and mark one as sufficient #301
Issue community tokens and mark one as sufficient #301
Conversation
7e9fa54
to
d7df042
Compare
d7df042
to
2560c03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took a while, I just couldn't convince myself that exposing methods to manage the assets through this pallet adds any major benefit to justify the extra code. Interacting directly with Assets pallet with the right origins should work for all our use-cases :)
If there's need to do transfers/holds/freezes of assets within this pallet we can still use the fungibles traits and derive the asset id from an established convention. e.g.
fn community_asset_id(id: &CommunityId, alt_asset: Option<AssetIndexOrNameOrSomeOtherIdentifier>) -> Option<AssetId> {
let id = alt_asset
.map(|alt| some_hashing((id, alt)))
.unwrap_or_else(|| id.into());
T::Assets::asset_exists(id).then_some(id)
}
I'm going to close for the mentioned reasons, if anything we reopen ;) |
No description provided.