feat: pjs vault #48
Open
feat: pjs vault #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.rs to use Generic type for Simple vault. Update Vault implementation in simple.rs to use Generic type for Simple vault
…od names in examples
Base automatically changed from
feat/libwallet-with-vault-exportin-signer
to
main
April 27, 2024 12:46
…struct. Add missing imports and fix formatting issues
olanod
reviewed
Apr 28, 2024
| type Account = Account; | ||
| type Error = Error; | ||
|
|
||
| async fn unlock( |
libwallet/src/vault/pjs.rs
Outdated
| .address() | ||
| .address(); | ||
|
|
||
| key.copy_from_slice(pub_key.as_bytes()); |
There was a problem hiding this comment.
The returned hex string should be decoded, otherwise I don't think you are getting the desired data.
…-rs to improve functionality and maintainability
…ount for better clarity
…the 'log' and 'hex' crates
…ension impl block
…0x" from the payload in the sign method. Fix log message in the sign method
…jsExtension implementation
olanod
force-pushed
the
main
branch
7 times, most recently
from
a53088f
to
7099446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.