Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ACI Spot virtual nodes support to virtual kubelet #192

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

feat: Add ACI Spot virtual nodes support to virtual kubelet #192

wants to merge 28 commits into from

Commits on Apr 5, 2022

  1. Add priority as annotation to use spot containers for virtual kubelet

    @telotlik
    telotlik committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    63da061 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Add new test to validate null priority

    @telotlik
    telotlik committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    151530d View commit details
    Browse the repository at this point in the history

  2. Updating priority check in pod annotation

    @telotlik
    telotlik committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    d8fda88 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Update tests and add priority annotation const

    @telotlik
    telotlik committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    74fd22c View commit details
    Browse the repository at this point in the history

  2. Update priority string check

    @telotlik
    telotlik committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    3f23906 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Iterate on ACI Spot CG on Virtual Kubelets - new function for propert… 

    …y set and update local test

- use constant variable for priority annotation keyname
- move the CG priority property set to a function
- Update Local Test
    @suselva
    suselva committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    d803498 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Merge pull request #1 from telotlik/users/suselva/aci-spot 

    Iterate on ACI Spot Changes
    @suselva
    suselva authored Apr 21, 2022
    Configuration menu
    Copy the full SHA
    b3bc432 View commit details
    Browse the repository at this point in the history

  2. api version when using priority

    @fnuarnav
    fnuarnav committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    cc15b33 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. update: set apiVersion based on extensible list of Tags

    @fnuarnav
    fnuarnav committed May 2, 2022
    Configuration menu
    Copy the full SHA
    c0e15d8 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. use VersioProvider to check ContainerGroupProperties

    @fnuarnav
    fnuarnav committed May 3, 2022
    Configuration menu
    Copy the full SHA
    fb1a943 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. fix indentation; validate version format

    @fnuarnav
    fnuarnav committed May 4, 2022
    Configuration menu
    Copy the full SHA
    bbc2355 View commit details
    Browse the repository at this point in the history

  2. Revert "fix indentation; validate version format" 

    This reverts commit bbc2355.
    @fnuarnav
    fnuarnav committed May 4, 2022
    Configuration menu
    Copy the full SHA
    c4c3b0a View commit details
    Browse the repository at this point in the history

  3. version set in code follows correct format

    @fnuarnav
    fnuarnav committed May 4, 2022
    Configuration menu
    Copy the full SHA
    bc57388 View commit details
    Browse the repository at this point in the history

  4. added unit tests for versioning

    @fnuarnav
    fnuarnav committed May 4, 2022
    Configuration menu
    Copy the full SHA
    49c3e26 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. update logging; use more c# style documentation comments

    @fnuarnav
    fnuarnav committed May 5, 2022
    Configuration menu
    Copy the full SHA
    2843053 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. remove print stmt; log uri in create

    @fnuarnav
    fnuarnav committed May 6, 2022
    Configuration menu
    Copy the full SHA
    f2a006a View commit details
    Browse the repository at this point in the history

  2. fix indents

    @fnuarnav
    fnuarnav committed May 6, 2022
    Configuration menu
    Copy the full SHA
    7f42078 View commit details
    Browse the repository at this point in the history

  3. use virtual-kubelet.io/priority; update comment

    @fnuarnav
    fnuarnav committed May 6, 2022
    Configuration menu
    Copy the full SHA
    2b1c322 View commit details
    Browse the repository at this point in the history

  4. use tag name virtual-kubelet.io-proprity

    @fnuarnav
    fnuarnav committed May 6, 2022
    Configuration menu
    Copy the full SHA
    a35c90a View commit details
    Browse the repository at this point in the history

  5. fix typo

    @fnuarnav
    fnuarnav committed May 6, 2022
    Configuration menu
    Copy the full SHA
    b75b772 View commit details
    Browse the repository at this point in the history

  6. set priority Tag with correct values only when priority annotaiton is… 

    … present
    @fnuarnav
    fnuarnav committed May 6, 2022
    Configuration menu
    Copy the full SHA
    bd6bc81 View commit details
    Browse the repository at this point in the history

  7. clean up code

    @fnuarnav
    fnuarnav committed May 6, 2022
    Configuration menu
    Copy the full SHA
    e222422 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. define priorityTagNae as a constant

    @fnuarnav
    fnuarnav committed May 9, 2022
    Configuration menu
    Copy the full SHA
    d780b79 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from telotlik/users/arnav/review-comments 

    addressing review comments
    @fnuarnav
    fnuarnav authored May 9, 2022
    Configuration menu
    Copy the full SHA
    35334f6 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into telotlik/VKACISpo… 

    …tContainers
    @fnuarnav
    fnuarnav committed May 9, 2022
    Configuration menu
    Copy the full SHA
    7c147e3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'telotlik/VKACISpotContainers' into users/arnav/api-version

    @fnuarnav
    fnuarnav committed May 9, 2022
    Configuration menu
    Copy the full SHA
    79ce469 View commit details
    Browse the repository at this point in the history

  5. fixed typo in comment

    @fnuarnav
    fnuarnav committed May 9, 2022
    Configuration menu
    Copy the full SHA
    9613c46 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. try adding parallelism to avoid timeout

    @fnuarnav
    fnuarnav committed May 10, 2022
    Configuration menu
    Copy the full SHA
    122d8bc View commit details
    Browse the repository at this point in the history