iFacialMocap support and some VRM fixes. #215
Conversation
| @@ -63,22 +63,40 @@ func _setup_vrm(model: VrmPuppet) -> Error: | |||
| add_child(armature_targets) | |||
|
|
|||
| if ik_targets.head != null: | |||
| armature_targets.add_child(ik_targets.head) | |||
| var marker_offset = Marker3D.new() | |||
There was a problem hiding this comment.
marker3ds aren't needed since all the needed ik targets are generated and managed by libvpuppr
There was a problem hiding this comment.
yeah it didn't help at all. I was experimenting with adding extra nodes so that the various IK points can be controlled manually in the inspector. I think this change isn't that helpful and so I might revert it. I'll split up these changes into separate PRs.
| @@ -6,7 +6,11 @@ echo "Updating git submodules" | |||
| git submodule update --init --recursive --remote | |||
|
|
|||
| echo "Building rust lib" | |||
| mv libvpuppr/target/debug/deps/libvpuppr.dll libvpuppr/target/debug/deps/libvpuppr.dll.bak || true | |||
There was a problem hiding this comment.
the backup files don't appear to be restored on error, so I think it would be better to just let the script error out.
In general, I think just letting the script throw an error is more optimal during development
There was a problem hiding this comment.
I used a bad filename. it's not really bak as in backup, but rather trash or deleteme.
Actually, maybe we should simply delete the old files instead of renaming. I'll see if that works.
Implement iFacialMocap
A few VRM fixes. Speed up import using uncompressed instead of basis.
Allow replacing GDExtension while running (still requires restart)