Correct tests for polyfill

virtualstate · Sep 12, 2023 · 8b4ead2 · 8b4ead2
1 parent dea3e9d
commit 8b4ead2
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 21 deletions.
diff --git a/README.md b/README.md
@@ -10,7 +10,7 @@ Native JavaScript [navigation](https://github.com/WICG/navigation-api) implement
 
  ### Test Coverage
 
- ![Web Platform Tests 129/237](https://img.shields.io/badge/Web%20Platform%20Tests-129%2F237-brightgreen) ![92.71%25 lines covered](https://img.shields.io/badge/lines-92.71%25-brightgreen) ![92.71%25 statements covered](https://img.shields.io/badge/statements-92.71%25-brightgreen) ![83.11%25 functions covered](https://img.shields.io/badge/functions-83.11%25-brightgreen) ![82.85%25 branches covered](https://img.shields.io/badge/branches-82.85%25-brightgreen)
+ ![Web Platform Tests 129/237](https://img.shields.io/badge/Web%20Platform%20Tests-129%2F237-brightgreen) ![92.48%25 lines covered](https://img.shields.io/badge/lines-92.48%25-brightgreen) ![92.48%25 statements covered](https://img.shields.io/badge/statements-92.48%25-brightgreen) ![82.03%25 functions covered](https://img.shields.io/badge/functions-82.03%25-brightgreen) ![80.84%25 branches covered](https://img.shields.io/badge/branches-80.84%25-brightgreen)
 
 [//]: # (badges)
 

diff --git a/example/polyfill-rollup.js b/example/polyfill-rollup.js
@@ -2072,12 +2072,6 @@ const globalWindow = typeof window === "undefined" ? undefined : window;
 
 const globalSelf = typeof self === "undefined" ? undefined : self;
 
-function isLike(value, ...and) {
-    if (!and.length)
-        return !!value;
-    return !!value && and.every((value) => !!value);
-}
-
 const NavigationKey = "__@virtualstate/navigation/key";
 const NavigationMeta = "__@virtualstate/navigation/meta";
 function getWindowHistory(givenWindow = globalWindow) {
@@ -2575,7 +2569,7 @@ function getCompletePolyfill(options = DEFAULT_POLYFILL_OPTIONS) {
                         }
                     });
                     function submit() {
-                        if (isLike(event.originalEvent)) {
+                        if (like(event.originalEvent)) {
                             const anchor = getAnchorFromEvent(event.originalEvent);
                             if (anchor) {
                                 return submitAnchor(anchor);

diff --git a/example/rollup.js b/example/rollup.js
diff --git a/src/get-polyfill.ts b/src/get-polyfill.ts
@@ -21,8 +21,6 @@ import {
 import {globalSelf} from "./global-self";
 import {v4} from "./util/uuid-or-random";
 import {NavigationHistoryEntrySerialized} from "./navigation-entry";
-import {isEvent} from "./event-target";
-import {isLike} from "@virtualstate/focus";
 
 export interface NavigationPolyfillOptions {
   /**
@@ -698,7 +696,7 @@ export function getCompletePolyfill(options: NavigationPolyfillOptions = DEFAULT
           });
 
           function submit() {
-            if (isLike<EventPrototype>(event.originalEvent)) {
+            if (like<EventPrototype>(event.originalEvent)) {
               const anchor = getAnchorFromEvent(event.originalEvent);
               if (anchor) {
                 return submitAnchor(anchor);

diff --git a/src/tests/navigation.scope.faker.ts b/src/tests/navigation.scope.faker.ts
@@ -48,11 +48,10 @@ function createElement(type: string) {
         });
     }
     target.matches = (query: string) => {
-        if (query === type) return true;
-        if (query === "a[href]") {
+        if (query.startsWith("a[href]")) {
             return type === "a" && !!target.href
         }
-        return false;
+        return query.startsWith(type);
     }
     target.appendChild = (child: { parentElement: unknown }) => {
         children.add(child)