Skip to content

Commit

Permalink
Merge pull request #22 from saasquatch/no-abort-controller
Browse files Browse the repository at this point in the history
Remove abort-controller
  • Loading branch information
fabiancook authored Sep 25, 2023
2 parents 6dcb449 + a525494 commit f394573
Show file tree
Hide file tree
Showing 8 changed files with 5 additions and 29 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Native JavaScript [navigation](https://html.spec.whatwg.org/multipage/nav-histor

<details><summary>Test Coverage</summary>

![Web Platform Tests 140/277](https://img.shields.io/badge/Web%20Platform%20Tests-140%2F277-brightgreen) ![92.8%25 lines covered](https://img.shields.io/badge/lines-92.8%25-brightgreen) ![92.8%25 statements covered](https://img.shields.io/badge/statements-92.8%25-brightgreen) ![83.33%25 functions covered](https://img.shields.io/badge/functions-83.33%25-brightgreen) ![82.97%25 branches covered](https://img.shields.io/badge/branches-82.97%25-brightgreen)


</details>

Expand Down
7 changes: 1 addition & 6 deletions example/polyfill-rollup.js
Original file line number Diff line number Diff line change
Expand Up @@ -450,15 +450,10 @@ function ok$1(value) {

const GlobalAbortController = typeof AbortController !== "undefined" ? AbortController : undefined;

// import ImportedAbortController from "abort-controller";
// async function importAbortController() {
// const { default: AbortController } = await import("abort-controller");
// return AbortController;
// }
if (!GlobalAbortController) {
throw new Error("AbortController expected to be available or polyfilled");
}
const AbortController$1 = GlobalAbortController; // await importAbortController();
const AbortController$1 = GlobalAbortController;

function isPromise(value) {
return (like(value) &&
Expand Down
7 changes: 1 addition & 6 deletions example/rollup.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 1 addition & 6 deletions example/routes-rollup.js
Original file line number Diff line number Diff line change
Expand Up @@ -2388,15 +2388,10 @@ function ok(value) {

const GlobalAbortController = typeof AbortController !== "undefined" ? AbortController : undefined;

// import ImportedAbortController from "abort-controller";
// async function importAbortController() {
// const { default: AbortController } = await import("abort-controller");
// return AbortController;
// }
if (!GlobalAbortController) {
throw new Error("AbortController expected to be available or polyfilled");
}
const AbortController$1 = GlobalAbortController; // await importAbortController();
const AbortController$1 = GlobalAbortController;

const Rollback = Symbol.for("@virtualstate/navigation/rollback");
const Unset = Symbol.for("@virtualstate/navigation/unset");
Expand Down
1 change: 0 additions & 1 deletion import-map-deno.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"iterable": "https://cdn.skypack.dev/[email protected]",
"https://cdn.skypack.dev/-/[email protected]/dist=es2019,mode=imports/optimized/iterable.js": "https://cdn.skypack.dev/[email protected]",
"uuid": "./src/util/deno-uuid.ts",
"abort-controller": "https://cdn.skypack.dev/abort-controller",
"deno:std/uuid/mod": "https://deno.land/[email protected]/uuid/mod.ts",
"deno:std/uuid/v4": "https://deno.land/[email protected]/uuid/v4.ts",
"deno:deno_dom/deno-dom-wasm.ts": "https://deno.land/x/deno_dom/deno-dom-wasm.ts",
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
"dependencies": {
"@ungap/structured-clone": "^1.0.2",
"@virtualstate/composite-key": "^1.0.0",
"abort-controller": "^3.0.0",
"uuid": "^8.3.2"
},
"devDependencies": {
Expand Down
8 changes: 1 addition & 7 deletions src/import-abort-controller.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
import { GlobalAbortController } from "./global-abort-controller";
// import ImportedAbortController from "abort-controller";

// async function importAbortController() {
// const { default: AbortController } = await import("abort-controller");
// return AbortController;
// }

if (!GlobalAbortController) {
throw new Error("AbortController expected to be available or polyfilled");
}

export const AbortController = GlobalAbortController; // await importAbortController();
export const AbortController = GlobalAbortController;
1 change: 0 additions & 1 deletion src/tests/dependencies-input.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ export const DefaultDependencies = [
"dom-lite",
"iterable",
"uuid",
"abort-controller",
"urlpattern-polyfill",
"@ungap/structured-clone",
"@ungap/structured-clone/json"
Expand Down

0 comments on commit f394573

Please sign in to comment.