Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing in the title from state #313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow passing in the title from state #313

wants to merge 1 commit into from

Conversation

mvhenten
Copy link

This would allow me to pass in "title" from "state". Furthermore, if I do so, I can avoid the dependency on document and use page.js to route server-side rendering.

@samccone
Copy link
Contributor

This is a reasonable change, however it is breaking since someone could be using state.title for something else.

For this PR to land we need to do the following:

  1. do a major semver bump.
  2. update the documentation around this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants