Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (nightly) no_std support #11

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Conversation

hobofan
Copy link
Contributor

@hobofan hobofan commented Jan 16, 2019

Fixes #10.

  • Inlined the ref_eq dependency, since that crate did not have no_std support and was only a single function
  • I had to add a dependency on libm, since core is currently lacking maths capabilites. See this RFC

@emilsjolander
Copy link
Contributor

@hobofan Actually should we also add a test to circle ci which ensures it compiles with no_std to ensure we don't regress this later?

@hobofan
Copy link
Contributor Author

hobofan commented Jan 16, 2019

Since it depends on nightly versions of Rust, this would make at least that portion of the tests really flakey, which is usually the reason why nightly builds are allowed to fail on Travis.

Last time I checked, support for a build matrix and allowed failures wasn't that great in CircleCI, but that might be outdated (either way I don't know enough about Circle to set it up properly).

On a related note: I'm working on cargo-nono. It's currently not very comprehensive in what it actually checks for in the the code, but I hope to soon add support for really obvious violations (e.g. use std::), and then it should also make sense to include it into CI builds to avoid regressions.

@emilsjolander
Copy link
Contributor

Awesome. That makes sense. Yeah let's leave it as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants