This repository has been archived by the owner on Jul 4, 2022. It is now read-only.
start implementing the new GeoInterface #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid having to define the geointerface over the generic JSON3.Object type
The geometry JSON objects generally only contain "type" and "coordinates". The type is already known since it is the name of the struct. Therefore we can just put the "coordinates" inside, which is a JSON3.Array. Doing some benchmarks on the previous geometry structs, which all needed to access the coordinates field, I found that simply accessing this field was quite slow. Implementing it this way avoids that cost. The downside is that "foreign members" that may be contained in the geometry object will be lost, however this is not required by the spec.
Just like JSON3.Array. This means a lot more methods will accept them.
From the geointerface get* functions. This ensures that the result of these functions also comply to the geointerface.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old branch, but it's good to have this available on master, as a starting point for the work in
JuliaGeo/GeoJSON.jl#36
and
#11