Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update refresh utils for React Router 7 support #363

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Conversation

ArnaudBarre
Copy link
Member

@ArnaudBarre ArnaudBarre commented Sep 7, 2024

Port of vitejs/vite-plugin-react-swc#191

cc @pcattori

__beforePerformReactRefresh & __getReactRefreshIgnoredExports will not be part of semver until RR7 is stable.

@ArnaudBarre ArnaudBarre changed the title Update refresh utils for Remix support Update refresh utils for React Router 7 support Sep 7, 2024
@ArnaudBarre ArnaudBarre changed the title Update refresh utils for React Router 7 support feat: update refresh utils for React Router 7 support Sep 7, 2024
@ArnaudBarre
Copy link
Member Author

@schiller-manuel from Tan stack start also want to try this out 🔥

Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems my suggestion made the lint CI to fail. LGTM if the lint fail is fixed.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the full context of what this is trying to solve, but code-wise it looks fine to me

@ArnaudBarre ArnaudBarre merged commit 4544e97 into main Sep 29, 2024
7 checks passed
@ArnaudBarre ArnaudBarre deleted the hmr-hooks branch September 29, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants