Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly export ssrRegisterHelper as const in plugin-vue-jsx (fix #376) #380

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

luckydye
Copy link
Contributor

Description

Fixes #376

"The Bun implementation of Function.toString differs from node, as described in oven-sh/bun#9543.
This causes the serialization of ssrRegisterHelper to output a incorrect string."

This change exports a const for the named export of the ssrRegisterHelper to make sure the name for the exported function exists. Will otherwise result in a parse error.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@edison1105
Copy link
Member

LGTM

Copy link

pkg-pr-new bot commented Nov 11, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@vitejs/plugin-vue@380
pnpm add https://pkg.pr.new/@vitejs/plugin-vue-jsx@380

commit: ea224cb

@yyx990803 yyx990803 merged commit 9c2b620 into vitejs:main Nov 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bun SSR failed to import "/__vue-jsx-ssr-register-helper"
3 participants