Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): should reload if relies file changed after re-render #471

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Nov 8, 2024

Description

close #7
close #8
close #386

see #7 (comment)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

pkg-pr-new bot commented Nov 8, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@vitejs/plugin-vue@471
pnpm add https://pkg.pr.new/@vitejs/plugin-vue-jsx@471

commit: 8939c88

@edison1105 edison1105 marked this pull request as draft November 8, 2024 14:46
@edison1105 edison1105 marked this pull request as ready for review November 9, 2024 01:45
@edison1105 edison1105 changed the title fix(HMR): hmr reload if relies file changed fix(hmr): should reload if relies file changed after re-render Nov 9, 2024
@yyx990803 yyx990803 merged commit 62b17f3 into main Nov 11, 2024
11 checks passed
@yyx990803 yyx990803 deleted the edison/fix/hmr branch November 11, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR with an external script does not proper reload 热更新失效
3 participants