fix: injects scripts into html files without any JS in mpa mode #17968
Conversation
|
|
| @@ -508,6 +508,12 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] { | |||
| transformIndexHtml(html, { chunk }) { | |||
| if (config.build.ssr) return | |||
| if (!chunk) return | |||
| if (!chunk.moduleIds.some((moduleId) => moduleId.endsWith('.js'))) { | |||
There was a problem hiding this comment.
I don't think this is the right check, probably chunk.imports.length === 0 is more correct?
There was a problem hiding this comment.
But in the following case, chunk.imports is an empty array, and index.html is the needs to include a polyfill script.
There was a problem hiding this comment.
Hmm strange, I was testing using playground/legacy/index.html locally and was able to see the imports have the JS chunks, not sure what's going on here.
There was a problem hiding this comment.
I added the config file
playground/legacy/vite.config-multiple-input.js
There was a problem hiding this comment.
I created the /playground/legacy/mpa/index.html and only-element.html files, you can see the image below, the imports array is empty. Would it be better to change the judgment condition to !chunk.moduleIds.some((moduleId) => moduleId.endsWith('.js')) && chunk.imports.length === 0
fix issues #17943
I'm not confident that my solution is sound, and if there are no issues, I plan to add unit tests.
The result after running locally:
