Deprecate mysqld in vitess/lite and use mysql:8.0.30 image for …

…the operator (#14990) Signed-off-by: Florent Poinsard <[email protected]>
vitessio · Jan 19, 2024 · 19a0242 · 19a0242
1 parent 22809e4
commit 19a0242
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 76 deletions.
diff --git a/Makefile b/Makefile
@@ -328,13 +328,6 @@ $(DOCKER_BASE_TARGETS): docker_base_%:
 
 docker_base_all: docker_base $(DOCKER_BASE_TARGETS)
 
-DOCKER_MYSQL_VERSIONS = 8.0.30 8.0.34
-docker_mysql:
-	for i in $(DOCKER_MYSQL_VERSIONS); do echo "building vitess/mysql:$$i"; ${call build_docker_image,docker/mysql/Dockerfile.$$i,vitess/mysql:$$i} || exit 1; done
-
-docker_mysql_push:
-	for i in $(DOCKER_MYSQL_VERSIONS); do echo "pushing vitess/mysql:$$i"; docker push vitess/mysql:$$i || exit 1; done
-
 docker_lite:
 	${call build_docker_image,docker/lite/Dockerfile,vitess/lite}
 

diff --git a/changelog/19.0/19.0.0/summary.md b/changelog/19.0/19.0.0/summary.md
@@ -6,8 +6,7 @@
   - **[Dropping Support for MySQL 5.7](#drop-support-mysql57)**
   - **[Deprecations and Deletions](#deprecations-and-deletions)**
     - [VTTablet Flags](#vttablet-flags)
-  - **[Docker](#docker)**
-    - [New MySQL Image](#mysql-image)
+    - [MySQL binary in vitess/lite Docker image](#mysql-binary-in-lite-image)
   - **[New Stats](#new-stats)**
     - [Stream Consolidations](#stream-consolidations)
     - [Build Version in `/debug/vars`](#build-version-in-debug-vars)
@@ -44,16 +43,24 @@ Vitess will however, continue to support importing from MySQL 5.7 into Vitess ev
 `--vreplication_healthcheck_topology_refresh`, `--vreplication_healthcheck_retry_delay`, and `--vreplication_healthcheck_timeout`.
 - The `--vreplication_tablet_type` flag is now deprecated and ignored.
 
+#### <a id="mysql-binary-in-lite-image"/>MySQL binary in vitess/lite Docker image
 
-### <a id="docker"/>Docker
+The `mysqld` binary is now deprecated in the `vitess/lite` Docker image and will be removed in a future release.
 
-#### <a id="mysql-image"/>New MySQL Image
+If you are currently using `vitess/lite` as your `mysqld` image in your vitess-operator deployment we invite you to use an official MySQL image such as `mysql:8.0.30`.
 
-In `v19.0` the Vitess team is shipping a new image: `vitess/mysql`.
-This lightweight image is a replacement of `vitess/lite` to only run `mysqld`.
-
-Several tags are available to let you choose what version of MySQL you want to use: `vitess/mysql:8.0.30`, `vitess/mysql:8.0.34`.
+Below is an example of a kubernetes yaml file before and after upgrading to an official MySQL image:
 
+```yaml
+# before
+    mysqld:
+      mysql80Compatible: vitess/lite:19.0.0
+```
+```yaml
+# after
+    mysqld:
+      mysql80Compatible: mysql:8.0.30 # or even mysql:8.0.34 for instance
+```
 
 ### <a id="new-stats"/>New Stats
 

diff --git a/docker/mysql/Dockerfile b/docker/mysql/Dockerfile
diff --git a/docker/mysql/Dockerfile.8.0.30 b/docker/mysql/Dockerfile.8.0.30
diff --git a/docker/mysql/Dockerfile.8.0.34 b/docker/mysql/Dockerfile.8.0.34
diff --git a/examples/operator/101_initial_cluster.yaml b/examples/operator/101_initial_cluster.yaml
@@ -15,7 +15,7 @@ spec:
     vtbackup: vitess/lite:latest
     vtorc: vitess/lite:latest
     mysqld:
-      mysql80Compatible: vitess/lite:latest
+      mysql80Compatible: mysql:8.0.30
     mysqldExporter: prom/mysqld-exporter:v0.11.0
   cells:
   - name: zone1

diff --git a/examples/operator/201_customer_tablets.yaml b/examples/operator/201_customer_tablets.yaml
@@ -11,7 +11,7 @@ spec:
     vtbackup: vitess/lite:latest
     vtorc: vitess/lite:latest
     mysqld:
-      mysql80Compatible: vitess/lite:latest
+      mysql80Compatible: mysql:8.0.30
     mysqldExporter: prom/mysqld-exporter:v0.11.0
   cells:
   - name: zone1

diff --git a/examples/operator/302_new_shards.yaml b/examples/operator/302_new_shards.yaml
@@ -11,7 +11,7 @@ spec:
     vtbackup: vitess/lite:latest
     vtorc: vitess/lite:latest
     mysqld:
-      mysql80Compatible: vitess/lite:latest
+      mysql80Compatible: mysql:8.0.30
     mysqldExporter: prom/mysqld-exporter:v0.11.0
   cells:
   - name: zone1

diff --git a/examples/operator/306_down_shard_0.yaml b/examples/operator/306_down_shard_0.yaml
@@ -11,7 +11,7 @@ spec:
     vtbackup: vitess/lite:latest
     vtorc: vitess/lite:latest
     mysqld:
-      mysql80Compatible: vitess/lite:latest
+      mysql80Compatible: mysql:8.0.30
     mysqldExporter: prom/mysqld-exporter:v0.11.0
   cells:
   - name: zone1