vttestserver: Rename the flag to initialize-with-vt-dba-tcp

Signed-off-by: Yohei Yoshimuta <[email protected]>
vitessio · Feb 27, 2024 · 6f5e853 · 6f5e853
1 parent 23123db
commit 6f5e853
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/go/cmd/vttestserver/cli/main.go b/go/cmd/vttestserver/cli/main.go
@@ -222,7 +222,7 @@ func New() (cmd *cobra.Command) {
 
 	cmd.Flags().DurationVar(&config.VtgateTabletRefreshInterval, "tablet_refresh_interval", 10*time.Second, "Interval at which vtgate refreshes tablet information from topology server.")
 
-	cmd.Flags().BoolVar(&doCreateTCPUser, "initialize_with_vt_dba_tcp", false, "If this flag is enabled, MySQL will be initialized with an additional user named vt_dba_tcp, who will have access via TCP/IP connection.")
+	cmd.Flags().BoolVar(&doCreateTCPUser, "initialize-with-vt-dba-tcp", false, "If this flag is enabled, MySQL will be initialized with an additional user named vt_dba_tcp, who will have access via TCP/IP connection.")
 	acl.RegisterFlags(cmd.Flags())
 
 	return cmd

diff --git a/go/cmd/vttestserver/cli/main_test.go b/go/cmd/vttestserver/cli/main_test.go
@@ -187,12 +187,12 @@ func TestForeignKeysAndDDLModes(t *testing.T) {
 }
 
 // TestCreateDbaTCPUser tests that the vt_dba_tcp user is created and can connect through TCP/IP connection
-// when --initialize_with_vt_dba_tcp is set to true.
+// when --initialize-with-vt-dba-tcp is set to true.
 func TestCreateDbaTCPUser(t *testing.T) {
 	conf := config
 	defer resetConfig(conf)
 
-	clusterInstance, err := startCluster("--initialize_with_vt_dba_tcp=true")
+	clusterInstance, err := startCluster("--initialize-with-vt-dba-tcp=true")
 	assert.NoError(t, err)
 	defer clusterInstance.TearDown()
 

diff --git a/go/flags/endtoend/vttestserver.txt b/go/flags/endtoend/vttestserver.txt
@@ -72,8 +72,8 @@ Flags:
       --grpc_server_keepalive_time duration                              After a duration of this time, if the server doesn't see any activity, it pings the client to see if the transport is still alive. (default 10s)
       --grpc_server_keepalive_timeout duration                           After having pinged for keepalive check, the server waits for a duration of Timeout and if no activity is seen even after that the connection is closed. (default 10s)
   -h, --help                                                             help for vttestserver
+      --initialize-with-vt-dba-tcp                                       If this flag is enabled, MySQL will be initialized with an additional user named vt_dba_tcp, who will have access via TCP/IP connection.
       --initialize_with_random_data                                      If this flag is each table-shard will be initialized with random data. See also the 'rng_seed' and 'min_shard_size' and 'max_shard_size' flags.
-      --initialize_with_vt_dba_tcp                                       If this flag is enabled, MySQL will be initialized with an additional user named vt_dba_tcp, who will have access via TCP/IP connection.
       --keep_logs duration                                               keep logs for this long (using ctime) (zero to keep forever)
       --keep_logs_by_mtime duration                                      keep logs for this long (using mtime) (zero to keep forever)
       --keyspaces strings                                                Comma separated list of keyspaces (default [test_keyspace])