rename TableSubquery to OutputsTable

Signed-off-by: Florent Poinsard <[email protected]>

go/test/endtoend/vtgate/queries/random/query_gen.go

@@ -46,7 +46,7 @@ type (
 
 	// queryGenerator generates queries, which can either be unions or select statements
 	queryGenerator struct {
-		stmt   sqlparser.SelectStatement
+		stmt   sqlparser.OutputsTable
 		selGen *selectGenerator
 	}
 

go/test/endtoend/vtgate/queries/random/simplifier_test.go

@@ -100,10 +100,10 @@ func simplifyResultsMismatchedQuery(t *testing.T, query string) string {
 	require.NoError(t, err)
 
 	simplified := simplifier.SimplifyStatement(
-		stmt.(sqlparser.SelectStatement),
+		stmt.(sqlparser.OutputsTable),
 		vSchemaWrapper.CurrentDb(),
 		vSchemaWrapper,
-		func(statement sqlparser.SelectStatement) bool {
+		func(statement sqlparser.OutputsTable) bool {
 			q := sqlparser.String(statement)
 			_, newErr := mcmp.ExecAllowAndCompareError(q, utils.CompareOptions{})
 			if newErr == nil {

go/test/vschemawrapper/vschema_wrapper.go

@@ -265,7 +265,7 @@ func (vw *VSchemaWrapper) FindTable(tab sqlparser.TableName) (*vindexes.Table, s
 	return table, destKeyspace, destTabletType, destTarget, nil
 }
 
-func (vw *VSchemaWrapper) FindView(tab sqlparser.TableName) sqlparser.TableSubquery {
+func (vw *VSchemaWrapper) FindView(tab sqlparser.TableName) sqlparser.OutputsTable {
 	destKeyspace, _, _, err := topoproto.ParseDestination(tab.Qualifier.String(), topodatapb.TabletType_PRIMARY)
 	if err != nil {
 		return nil

go/vt/sqlparser/ast.go

@@ -62,8 +62,8 @@ type (
 		GetLimit() *Limit
 	}
 
-	TableSubquery interface {
-		iTableSubquery()
+	OutputsTable interface {
+		iOutputsTable()
 
 		InsertRows
 		Statement
@@ -184,7 +184,7 @@ type (
 	CommonTableExpr struct {
 		ID       IdentifierCS
 		Columns  Columns
-		Subquery TableSubquery
+		Subquery OutputsTable
 	}
 	// ChangeColumn is used to change the column definition, can also rename the column in alter table command
 	ChangeColumn struct {
@@ -326,8 +326,8 @@ type (
 	// Union represents a UNION statement.
 	Union struct {
 		With     *With
-		Left     TableSubquery
-		Right    TableSubquery
+		Left     OutputsTable
+		Right    OutputsTable
 		Distinct bool
 		OrderBy  OrderBy
 		Limit    *Limit
@@ -566,7 +566,7 @@ type (
 		Definer     *Definer
 		Security    string
 		Columns     Columns
-		Select      TableSubquery
+		Select      OutputsTable
 		CheckOption string
 		IsReplace   bool
 		Comments    *ParsedComments
@@ -579,7 +579,7 @@ type (
 		Definer     *Definer
 		Security    string
 		Columns     Columns
-		Select      TableSubquery
+		Select      OutputsTable
 		CheckOption string
 		Comments    *ParsedComments
 	}
@@ -775,10 +775,10 @@ func (*Analyze) iStatement()               {}
 func (*OtherAdmin) iStatement()            {}
 func (*CommentOnly) iStatement()           {}
 func (*Select) iSelectStatement()          {}
-func (*Select) iTableSubquery()            {}
+func (*Select) iOutputsTable()             {}
 func (*ValuesStatement) iSelectStatement() {}
 func (*Union) iSelectStatement()           {}
-func (*Union) iTableSubquery()             {}
+func (*Union) iOutputsTable()              {}
 func (*Load) iStatement()                  {}
 func (*CreateDatabase) iStatement()        {}
 func (*AlterDatabase) iStatement()         {}
@@ -2137,13 +2137,13 @@ type (
 
 	// Subquery represents a subquery used as an value expression.
 	Subquery struct {
-		Select TableSubquery
+		Select OutputsTable
 	}
 
 	// DerivedTable represents a subquery used as a table expression.
 	DerivedTable struct {
 		Lateral bool
-		Select  TableSubquery
+		Select  OutputsTable
 	}
 )