Skip to content

Commit

Permalink
Update to latest Nodejs LTS and NPM (#17606)
Browse files Browse the repository at this point in the history
Signed-off-by: Dirkjan Bussink <[email protected]>
  • Loading branch information
dbussink authored Jan 23, 2025
1 parent 91dd79d commit f2827f9
Show file tree
Hide file tree
Showing 13 changed files with 4,616 additions and 3,701 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check_make_vtadmin_web_proto.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
with:
# node-version should match package.json
node-version: '20.12.2'
node-version: '22.13.1'

- name: Install npm dependencies
if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.proto_changes == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static_checks_etc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ jobs:
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
with:
# make proto requires newer node than the pre-installed one
node-version: '20.12.2'
node-version: '22.13.1'

- name: check_make_proto
if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.proto_changes == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vtadmin_web_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
if: steps.skip-workflow.outputs.skip-workflow == 'false'
with:
# node-version should match package.json
node-version: '20.12.2'
node-version: '22.13.1'

- name: Install dependencies
if: steps.skip-workflow.outputs.skip-workflow == 'false'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vtadmin_web_lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
if: steps.skip-workflow.outputs.skip-workflow == 'false'
with:
# node-version should match package.json
node-version: '20.12.2'
node-version: '22.13.1'

- name: Install dependencies
if: steps.skip-workflow.outputs.skip-workflow == 'false'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vtadmin_web_unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
if: steps.skip-workflow.outputs.skip-workflow == 'false'
with:
# node-version should match package.json
node-version: '20.12.2'
node-version: '22.13.1'

- name: Install dependencies
if: steps.skip-workflow.outputs.skip-workflow == 'false'
Expand Down
9 changes: 9 additions & 0 deletions changelog/22.0/22.0.0/summary.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
- **[Minor Changes](#minor-changes)**
- **[VTTablet Flags](#flags-vttablet)**
- **[Topology read concurrency behaviour changes](#topo-read-concurrency-changes)**
- **[VTAdmin](#vtadmin)**
- [Updated to node v22.13.1](#updated-node)

## <a id="major-changes"/>Major Changes</a>

Expand Down Expand Up @@ -150,3 +152,10 @@ While the flag will continue to accept float values (interpreted as seconds) for
The `--topo_read_concurrency` flag was added to all components that access the topology and the provided limit is now applied separately for each global or local cell _(default `32`)_.

All topology read calls _(`Get`, `GetVersion`, `List` and `ListDir`)_ now respect this per-cell limit. Previous to this version a single limit was applied to all cell calls and it was not respected by many topology calls.

### <a id="vtadmin"/>VTAdmin

#### <a id="updated-node"/>vtadmin-web updated to node v22.13.1 (LTS)

Building `vtadmin-web` now requires node >= v22.13.0 (LTS). Breaking changes from v20 to v22 can be found at https://nodejs.org/en/blog/release/v22.13.0 -- with no known issues that apply to VTAdmin.
Full details on the node v20.12.2 release can be found at https://nodejs.org/en/blog/release/v22.13.1.
2 changes: 1 addition & 1 deletion docker/binaries/vtadmin/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ ARG DEBIAN_VER=bookworm-slim

FROM vitess/lite:${VT_BASE_VER} AS lite

FROM node:20-${DEBIAN_VER} as node
FROM node:22-${DEBIAN_VER} as node

# Prepare directory structure.
RUN mkdir -p /vt/web
Expand Down
4 changes: 2 additions & 2 deletions web/vtadmin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

## Prerequisites

- [node](https://nodejs.org) >= 20.12.0 LTS
- npm >= 10.5.0 (comes with node)
- [node](https://nodejs.org) >= 22.13.1 LTS
- npm >= 10.9.2 (comes with node)

## Available scripts

Expand Down
2 changes: 1 addition & 1 deletion web/vtadmin/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ if [[ -z ${NVM_DIR} ]]; then
fi

if [[ -z ${NODE_VERSION} ]]; then
export NODE_VERSION="20.12.2"
export NODE_VERSION="22.13.1"
fi

output "\nInstalling nvm...\n"
Expand Down
Loading

0 comments on commit f2827f9

Please sign in to comment.