-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schemadiff: improved heuristic for dependent migration permutation evaluation time #14249
Merged
rohit-nayak-ps
merged 7 commits into
vitessio:main
from
planetscale:schemadiff-ordered-diffs-heuristic-order
Oct 18, 2023
Merged
schemadiff: improved heuristic for dependent migration permutation evaluation time #14249
rohit-nayak-ps
merged 7 commits into
vitessio:main
from
planetscale:schemadiff-ordered-diffs-heuristic-order
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Oct 11, 2023
Signed-off-by: Shlomi Noach <[email protected]>
… skips impossible permutations Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…here's pairs of types of diffs for which we can skip swapping and thus can shorten the search path Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Oct 15, 2023
Signed-off-by: Shlomi Noach <[email protected]>
dbussink
approved these changes
Oct 16, 2023
rohit-nayak-ps
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See story in #14248. In this PR:
DROP
s come first, thenALTER
s, thenCREATE
s) before evaluating dependency permutations. This begins the search with a heuristically probable solution, and followed by "nearby" solutions.context.Context
for premature exit. This changes the function signature forOrderedDiffs(...)
Related Issue(s)
Fixes #14248
Checklist
Deployment Notes