Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullability checks in evalengine #14556

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix nullability checks in evalengine #14556

merged 1 commit into from
Nov 21, 2023

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Nov 21, 2023 •
edited by dbussink
Loading

A number of expressions and function implementations in the evalengine were not correctly propagating the nullable checks. For example the multiplication operation didn't do this. This can lead to crashes in the evalengine.

Here the flags have been audited and set properly. New test inputs are also added to ensure we exercise more of these paths.

Related Issue(s)

Fixes #14558

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 21, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 21, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 21, 2023
@dbussink dbussink changed the title Add panicking test Fix nullability checks in evalengine Nov 21, 2023
@dbussink dbussink added Type: Bug Component: Evalengine changes to the evaluation engine Backport to: release-17.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 21, 2023
@dbussink dbussink marked this pull request as ready for review November 21, 2023 10:25
@GuptaManan100 @dbussink
evalengine: Fix nullable handling
3e3a3d0 
A number of expressions and function implementations in the evalengine
were not correctly propagating the nullable checks. For example the
multiplication operation didn't do this. This can lead to crashes in the
evalengine.

Here the flags have been audited and set properly. New test inputs are
also added to ensure we exercise more of these paths.

Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
vmg
vmg approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@vmg vmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite comprehensive. Good job folks!

@dbussink dbussink merged commit bdab2bf into vitessio:main Nov 21, 2023
115 checks passed
@dbussink dbussink deleted the panic-eval branch November 21, 2023 13:09
This was referenced Nov 21, 2023
Merged
Merged
GuptaManan100 added a commit that referenced this pull request Nov 21, 2023
@GuptaManan100
Fix nullability checks in evalengine (#14556)
fd629d9 
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
frouioui pushed a commit that referenced this pull request Nov 21, 2023
@vitess-bot @GuptaManan100
[release-18.0] Fix nullability checks in evalengine (#14556) (#14564)
bacb477 
Co-authored-by: Manan Gupta <[email protected]>
GuptaManan100 added a commit to planetscale/vitess that referenced this pull request Nov 22, 2023
@GuptaManan100
Fix nullability checks in evalengine (vitessio#14556)
9badb73 
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
systay pushed a commit that referenced this pull request Nov 23, 2023
@vitess-bot @GuptaManan100
[release-17.0] Fix nullability checks in evalengine (#14556) (#14563)
8898c37 
Co-authored-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@GuptaManan100 @ejortegau
Fix nullability checks in evalengine (vitessio#14556)
1b6d257 
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmg vmg vmg approved these changes

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
Component: Evalengine changes to the evaluation engine Type: Bug
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: evalengine crashes on expression with multiplication and null
3 participants
@GuptaManan100 @dbussink @vmg