adds optional window function to aggregate functions in sqlparser #15382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#5852)
Description
I had a PR for this work before. I went ahead and pushed the changes at the tip of main. Unsure what else I need to do but I am hoping this could be added to the sqlparser so I can move back to using released code again. Thanks!
This adds additional functionality to the sqlparser to support window functions associated to aggregate functions. #4099 new window function capabilities was added but it seemed to miss adding it to aggregate functions like COUNT, SUM, AVG, etc. This will add the OVER CLAUSE associated to existing aggregate functions.
ADDED AGGREGATE FUNCTIONS
This does not implement
JSON_ARRAYAGG()
orJSON_OBJECTAGG()
and the related over clause that can be added to them.Related Issue(s)
#4099
#5852
Checklist
Deployment Notes