Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all actions setup to latest versions #15443

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

dbussink
Copy link
Contributor

This fixes a number of deprecation warnings around older Node versions used by some of these actions. With this we're on the latest releases again.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

This fixes a number of deprecation warnings around older Node versions
used by some of these actions. With this we're on the latest releases
again.

Signed-off-by: Dirkjan Bussink <[email protected]>
Copy link
Contributor

vitess-bot bot commented Mar 11, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 11, 2024
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 11, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 11, 2024
@frouioui
Copy link
Member

frouioui commented Mar 11, 2024

Is that something we want to backport to all release branches? Personally, I am not against it

@dbussink
Copy link
Contributor Author

Is that something we want to backport to all release branches? Personally, I am not against it

Probably good to avoid any surprises down the line if the deprecation breaks something.

@dbussink dbussink added Backport to: release-17.0 Backport to: release-19.0 Needs to be back ported to release-19.0 labels Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.66%. Comparing base (46975b2) to head (0ffebe1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15443      +/-   ##
==========================================
+ Coverage   65.64%   65.66%   +0.01%     
==========================================
  Files        1563     1563              
  Lines      194380   194380              
==========================================
+ Hits       127608   127636      +28     
+ Misses      66772    66744      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink dbussink merged commit 2830a07 into vitessio:main Mar 11, 2024
118 of 120 checks passed
@dbussink dbussink deleted the dbussink/update-actions-deps branch March 11, 2024 16:03
vitess-bot pushed a commit that referenced this pull request Mar 11, 2024
dbussink pushed a commit that referenced this pull request Mar 11, 2024
…15446)

Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
dbussink pushed a commit that referenced this pull request Mar 11, 2024
…15445)

Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
dbussink pushed a commit that referenced this pull request Mar 13, 2024
…15444)

Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants