Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing ExecuteMultiFetchAsDba gRPC and vtctldclient ExecuteMultiFetchAsDBA command #15506

Merged
merged 20 commits into from
Mar 19, 2024

remvoe unused Errors field

fdabcfb
Select commit
Loading
Failed to load commit list.
Merged

Introducing ExecuteMultiFetchAsDba gRPC and vtctldclient ExecuteMultiFetchAsDBA command #15506

remvoe unused Errors field
fdabcfb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 18, 2024 in 1s

65.61% (-1.81%) compared to 696fe0e

View this Pull Request on Codecov

65.61% (-1.81%) compared to 696fe0e

Details

Codecov Report

Attention: Patch coverage is 35.00000% with 117 lines in your changes are missing coverage. Please review.

Project coverage is 65.61%. Comparing base (696fe0e) to head (fdabcfb).
Report is 119 commits behind head on main.

Files Patch % Lines
go/cmd/vtctldclient/command/query.go 14.70% 29 Missing ⚠️
go/vt/vttablet/grpctmclient/client.go 0.00% 25 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_query.go 64.00% 18 Missing ⚠️
go/vt/wrangler/tablet.go 0.00% 11 Missing ⚠️
go/vt/vttablet/grpctmserver/server.go 0.00% 9 Missing ⚠️
go/vt/vttablet/tmrpctest/test_tm_rpc.go 0.00% 8 Missing ⚠️
...t/vtctl/grpcvtctldserver/testutil/test_tmclient.go 46.15% 7 Missing ⚠️
go/vt/vtctl/grpcvtctldclient/client_gen.go 0.00% 4 Missing ⚠️
go/vt/vtcombo/tablet_map.go 0.00% 2 Missing ⚠️
go/vt/vtctl/localvtctldclient/client_gen.go 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15506      +/-   ##
==========================================
- Coverage   67.41%   65.61%   -1.81%     
==========================================
  Files        1560     1563       +3     
  Lines      192752   194638    +1886     
==========================================
- Hits       129952   127703    -2249     
- Misses      62800    66935    +4135

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov